Repository navigation
fix(pages): hydrate islands added while the dev server runs - #870
Draft
liangmiQwQ wants to merge 1 commit into
Draft
liangmiQwQ wants to merge 1 commit into
liangmiQwQ wants to merge 1 commit into
Conversation
Member
|
Two issues, slop explanation:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an island page gains a new island import while the dev server is running, the new island never hydrates. The page HTML includes its
data-islandwrapper, butvirtual:void-islands-clientkeeps serving the module it generated before the edit, so the island has no loader. Reloading doesn't help; only a server restart does. Reproduction: https://github.com/liang-demos/void-vue-island-hmr-reproThe page transform records the new island in the manifest, but nothing invalidates the client entry afterwards. This PR lets the island manifest keep a reference to the dev server. When
register()records a new island, or an island that now resolves to a different file, it invalidates the client entry in every environment. The next page load then picks it up. The React, Vue, Svelte and Solid adapters pass the server to the manifest fromconfigureServer.🤖 Generated with Claude Code